-
-
Notifications
You must be signed in to change notification settings - Fork 400
Limit all resolutions on MacOS to currently selected resolution in the system #9323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ihhub IMHO, in a good way, it would be worth to get the resolution info about the display where the fheroes2 is currently running (using the SDL_GetWindowDisplayIndex()
) and not just the first display (although of course I'm not sure about this, because the user can drag the game between the displays). Regarding macOS, what do you think about choosing the "minimum max resolution" among all displays (but maybe the one that is still not less than 640x480?) and using it as an upper bound? After all, the user can drag the game between the displays, can this lead to switching the display mode on macOS?
Hi @oleg-derevenetz , these are very good points. I will update the code based on your comment |
Hi @oleg-derevenetz , could you please take care about the development of the project for the next 3 weeks as I need to take a personal break and I will not have access to any of my machines expect my phone? |
Hi @ihhub
Going on vacation? :) Yes, well, I'll do my best to keep an eye on the project. |
Yes, my longest vacation in the last 10+ years :) I will still be active tomorrow and come back to the project on 15th April. Thank you so much! |
We need to be careful while limiting resolutions on user's machines. At the moment resolution limited being tested on MacOS only.
close #9273