This should make MAM in Oracle >= 12 work #180
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was this not merged because I messed up the formatting? |
We just have very few volunteers efforting code reviews and maintaining repos these days. We are always looking for more folks that can do so! |
|
I've looked at this a couple of times. Whilst it looks sound, I'd prefer to
get an Oracle test environment for it (and maybe even put in some CI so
that this doesn't happen again). Turns out, Oracle make that difficult if
you don't wanna pay for it.
…On Fri, 7 May 2021, 14:29 daryl herzmann, ***@***.***> wrote:
Was this not merged because I messed up the formatting?
We just have very few volunteers efforting code reviews and maintaining
repos these days. We are always looking for more folks that can do so!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQE3W3TQUFW3NQKSWEVC53TMPTKJANCNFSM4Y7LWHEQ>
.
|
Oracle XE is free, they even give some scripts to build some Docker images for it ( though for some reason don’t host up to say images on Docker Hub) |
|
That's as far as I got too.
I wanted to ponder the security implications of building an image that'll
inevitably not get maintained into the CI chain, and went looking for an
official "example" or similar. All I found were other people's built
images, but given the build method, there's no guarantees that can be made
on provenance.
…On Fri, 7 May 2021, 22:45 GregDThomas, ***@***.***> wrote:
Turns out, Oracle make that difficult if you don't wanna pay for it.
Oracle XE is free, they even give some scripts to build some Docker images
for it ( though for some reason don’t host up to say images on Docker Hub)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQE3W23DKSSHTXRS5QDM33TMRNNNANCNFSM4Y7LWHEQ>
.
|
akrherz
force-pushed
the
main
branch
2 times, most recently
from
7c7c5d4 to
e6ba183
Compare
|
Eek. I did not intent to close this PR, only to rebase it. |
|
There's some magic with regards to the branch rename, maybe(?) that prevents me to re-open this PR. I've created a new PR with the same changes, here: #382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Found a bug in the Monitoring Plugin. The SQL Query generated was always ended by a LIMIT clause.
See https://discourse.igniterealtime.org/t/mam-sql-command-not-properly-ended/89822.