Skip to content

Database errors should cause an XMPP error #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guusdk opened this issue Dec 11, 2020 · 1 comment
Closed

Database errors should cause an XMPP error #148

guusdk opened this issue Dec 11, 2020 · 1 comment

Comments

@guusdk
Copy link
Member

guusdk commented Dec 11, 2020

When there's an issue interacting with the database while retrieving messages, those issues are currently ignored. This leads to results that are incomplete.

Fail-fast behavior is desired here: when there's a database error, thrown an exception.

It's probably best to make this configurable, to allow administrators to fall back to ignoring errors, for those instances where, for a reason that's currently beyond me, have significant amounts of database issues.

@guusdk
Copy link
Member Author

guusdk commented Dec 11, 2020

The property that can be used to control this behavior is archive.ignore-retrieval-exceptions. It's value is a boolean. false, which will be the new default, will cause XMPP errors to be generated, while true restores the old behavior of ignoring errors.

guusdk added a commit to guusdk/openfire-monitoring-plugin that referenced this issue Dec 11, 2020
When there's an issue interacting with the database while retrieving messages, those issues are currently ignored. This leads to results that are incomplete.

Fail-fast behavior is desired here: when there's a database error, thrown an exception.

It's probably best to make this configurable, to allow administrators to fall back to ignoring errors, for those instances where, for a reason that's currently beyond me, have significant amounts of database issues.

The property that can be used to control this behavior is archive.ignore-retrieval-exceptions. It's value is a boolean. false, which will be the new default, will cause XMPP errors to be generated, while true restores the old behavior of ignoring errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant