Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imported] Replace broken lecloud links with the original author's tumblr links #256

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

ido777
Copy link
Owner

@ido777 ido777 commented Apr 6, 2025

Imported from donnemartin/system-design-primer#1010

Original author: @ykeremy


Fixes donnemartin#1009

@Copilot Copilot bot review requested due to automatic review settings April 6, 2025 20:17
@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported comment from @ykeremy

BTW just noticed that it's not these specific links that are broken, for more context: https://x.com/internetarchive.

I think we should still merge this PR since it also updates the translated pages to point to LeCloud's tumblr page. Your call @donnemartin

@ido777
Copy link
Owner Author

ido777 commented Apr 6, 2025

Imported review by @touero

State: APPROVED

No content

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@ido777 ido777 merged commit 2c5008d into main Apr 7, 2025
@ido777 ido777 deleted the imported-pr-1010 branch April 7, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System Design for Dummies links are broken
2 participants