Use ceil on svg dimensions, fix svg memory usage ref #841 #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
requested changes
Jul 15, 2021
wgpu/src/image/vector.rs
Outdated
| @@ -122,6 +122,7 @@ impl Cache { | |||
| device, | |||
| encoder, | |||
| )?; | |||
| log::warn!("allocating {} {}x{}", id, width, height); | |||
There was a problem hiding this comment.
I think this should be debug or trace level.
There was a problem hiding this comment.
ok i changed to debug. i do think warn is useful to see how much allocating, since it should really be never once application is running, but i do see it reallocating if for example i change svg icon / button depending on some state, but it's ok for me to make debug
Calls ceil() on dimension bounds as this appears fix svg memory unbounded usage because no longer cache miss. The height and width return from resvg seem to always be ceiling of float dimensions, so we try to match.
This was referenced Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls ceil() on dimension bounds as this appears fix svg memory
unbounded usage because no longer cache miss.
The height and width return from resvg seem to always be ceiling
of float dimensions, so we try to match.