Expose underlying mobile support from winit via cfg changes #2952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand mobile support is not a priority, and possibly even a detriment if it attracts more spurious bug reports. But, with just 6 lines of code changes
iced
can expose underlingwinit
android support. This goes a long way to closing #302 with no ongoing maintenance from iced core team.4 lines are cfg changes that more closely align with the underlying winit library
Checking only for wasm32 let's unsupported platforms slip through the feature gate of KeyEventExtModifierSupplement, because the underlying core winit library uses a different set of platform checks.
This will allow more platform support transparently by matching the cfg of the underlying winit library.
winit
0.31 plans to remove config aliases in favor of raw cfg macros. rust-windowing/winit#3539Lastly, re-exporting 2
winit
features into the iced_winit workspace Cargo allows the underlyingwinit
+android-activity
to build when targetingaarch64-linux-android
There are all the changes to allow successful building on android - fonts don't work, but that is another small pr.