Skip to content

Fix Widget::tag implementation of pure::Canvas #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Jul 1, 2022

Using P::State can cause a panic if the Canvas has () as P::State and replaces a stateless widget in a future view call.

Related to #1309.

Using `P::State` can cause a panic if the `Canvas` has `()` as
`P::State` and replaces a stateless widget in a future `view` call.
@hecrj hecrj added bug Something isn't working widget canvas labels Jul 1, 2022
@hecrj hecrj added this to the 0.4.3 milestone Jul 1, 2022
@hecrj hecrj merged commit ca185c3 into master Jul 1, 2022
@hecrj hecrj deleted the fix/canvas-state-tag branch July 1, 2022 02:00
hecrj added a commit that referenced this pull request Jul 1, 2022
Fix `Widget::tag` implementation of `pure::Canvas`
@hecrj hecrj modified the milestones: 0.4.3, 0.5.0 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working canvas widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant