Skip to content

Implemented Tooltip as Pure #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2022
Merged

Implemented Tooltip as Pure #1315

merged 3 commits into from
Apr 25, 2022

Conversation

casperstorm
Copy link
Member

This PR introduces a pure Tooltip.

  • (Re)implemented Tooltip as pure
  • Added Example to /examples/pure/tooltip
  • Corrected variable name in native/src/widget/tooltip.rs

tooltip

@hecrj hecrj added feature New feature or request widget labels Apr 24, 2022
hecrj
hecrj approved these changes Apr 24, 2022
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I made some small changes to expose the Position enum from iced_native instead of duplicating it in 011b7d1 and refactored the draw logic so we can reuse it in e33f43a.

I think we can merge this! 🥳

@hecrj hecrj merged commit bba4cf3 into iced-rs:master Apr 25, 2022
@hecrj hecrj mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
feature New feature or request widget
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casperstorm @hecrj