Skip to content

Slider fix #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2022
Merged

Slider fix #1286

merged 1 commit into from
Mar 29, 2022

Conversation

ThisIsRex
Copy link
Contributor

Fixed rail position. Fixed incorrect handle position with large radius/width/border width

@hecrj
Copy link
Member

hecrj commented Mar 21, 2022

Thanks for looking into this!

Could you share an SSCCE of the issue these changes are meant to fix?

@hecrj hecrj added bug Something isn't working widget labels Mar 21, 2022
@hecrj hecrj added this to the 0.4.0 milestone Mar 21, 2022
@ThisIsRex
Copy link
Contributor Author

Thanks for looking into this!

Could you share an SSCCE of the issue these changes are meant to fix?

Sure, here it is main.rs.txt
I used a git repository as a dependecy

before:
ezgif-4-1e40769b21

after:
ezgif-4-38e225cc87

hecrj
hecrj approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Not sure what I was thinking when I wrote the handle position logic 😅

@hecrj hecrj merged commit 662c764 into iced-rs:master Mar 29, 2022
@hecrj hecrj mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working rendering widget
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ThisIsRex @hecrj