-
Notifications
You must be signed in to change notification settings - Fork 42
BOP-Elites #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BOP-Elites #496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @szhaovas! Left a bunch of comments. I haven't really looked at the emitter and scheduler themselves yet; I'll wait for you to fix the big things like how the scheduler works before taking a closer look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More changes. Thanks Shihan! I'll review the emitter later. I did take a look at the scheduler; it makes sense to me.
@szhaovas could you also add tests that, at a minimum, call the emitter and scheduler to make sure they work? For reference, you can see this emitter test https://github.com/icaros-usc/pyribs/blob/master/tests/emitters_pycma/pycma_es_test.py and the current scheduler file https://github.com/icaros-usc/pyribs/blob/master/tests/schedulers/scheduler_test.py |
## Description <!-- Provide a brief description of the PR's purpose here. --> This method changes the dimensionality of the grid in a `GridArchive`, e.g., we can go from `10x10` to `20x20` or `5x5`. This method was introduced by @szhaovas in #496. Here, I've split it out into a separate PR that re-implements it as an in-place method on the archive, i.e., the archive will be retessellated in-place. ## TODO <!-- Notable points that this PR has either accomplished or will accomplish. --> - [x] Implement retessellate - [x] Add tests ## Status - [x] I have read the guidelines in [CONTRIBUTING.md](https://github.com/icaros-usc/pyribs/blob/master/CONTRIBUTING.md) - [x] I have formatted my code using `yapf` - [x] I have tested my code by running `pytest` - [x] I have linted my code with `pylint` - [x] I have added a one-line description of my change to the changelog in `HISTORY.md` - [x] This PR is ready to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix up minor remaining comments and merge. Good job @szhaovas!
…into retessellate
Description
Implement BOP-Elites.
TODO
Questions
Status
CONTRIBUTING.md
yapf
pytest
pylint
HISTORY.md