Skip to content

Feat/input text prediction #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Ayatallah
Copy link
Contributor

#3 Predict sentiment analysis of input text:

  1. Used joblib to save scikitlearn classification model
  2. Introduced two methods save_model and load_model to save models after training or load them for direct usage

#14 Concert Script into OOP Format

  1. Replaced model.py with 4 files model.py, doc2vec_model.py, classifier_model.py, text_classifier.py
  • model.py is an abstract class defining methods any model should do
  • doc2vec_model.py and classifier_model.py extending model.py
  • text_classifier.py is separate object that own dataset, doc2vec model, classification model and methods to train or test the whole model
  1. Updated project structure with files increasing to enhance easily development
  2. Replaced all path used with relative paths
  3. Added mode (test/train) and filename of dataset to be used, filename of the doc2vec model to load/save trained model into, filename of classification model to load/save trained model into to the list of input provided by user when running the project form command line

Please review and let me know what you think!

@ibrahimsharaf
Copy link
Owner

Hi @Ayatallah, thank you for the PR! for starters, let's split this PR into multiple ones, in order to be self-contained for easier reviewing. shall we start with issue (#14)? also rebase on master branch (to update your fork and remove previous commits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants