fix(clickhouse): use named rather than positional group by #6106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll stop work on this for now because it's clear that in the tests using positional arguments was intentional. It would probably benefit from a look over from someone more familiar with |
gforsyth
requested changes
Apr 28, 2023
There was a problem hiding this comment.
Hey @JackFielding -- thanks for putting this in! This looks like a reasonable change to me -- the failing tests are SQL snapshot tests and this change is (understandably) changing that output to something semantically equivalent but not explicitly equal.
You can update the snapshot files by running pytest --snapshot-update
cpcloud
force-pushed
the
clickhouse-not-positional-group-by
branch
from
ce17f3e to
e355d0a
Compare
cpcloud
added
bug
cpcloud
approved these changes
Apr 28, 2023
|
Merging! |
|
Thanks for the PR @JackFielding! |
|
Thank you both for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6101