docs: fix relative links in tutorial #4226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjakefala
force-pushed
the
docs-relative
branch
from
c9e61b4 to
ead6792
Compare
Codecov Report
@@ Coverage Diff @@
## master #4226 +/- ##
===========================================
- Coverage 92.58% 35.29% -57.29%
===========================================
Files 179 158 -21
Lines 20218 18346 -1872
Branches 2890 2670 -220
===========================================
- Hits 18718 6476 -12242
- Misses 1135 11652 +10517
+ Partials 365 218 -147
|
cpcloud
added
ddl
mkdocs-jupyter cannot find relative links in upper directories with the standard markdown syntax (danielfrg/mkdocs-jupyter#27). Closes ibis-project#4064, closes ibis-project#4201
cpcloud
approved these changes
Aug 1, 2022
|
Looks like it's working nicely! https://ibis-project.org/docs/dev/tutorial/01-Introduction-to-Ibis/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkdocs-jupyter cannot find relative links in upper directories with the
standard markdown syntax
(danielfrg/mkdocs-jupyter#27). Switching to using relative hyperlinking with
<a>.Closes #4064, closes #4201
I tried to test using
mikeversioning in my local build, but had a hard time figuring out how to add mydocs-relativebranch to it. I tested with the basicmkdocs serveto make sure it was at least functional there.mikeadvice is welcome. Otherwise this has a decent chance of succeeding, and I feel worth trying out with thedevdocs.