feat: add Schema.from_sqlglot method to produce an Ibis schema from SQLGlot
#11351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndexSeek
force-pushed
the
feat-from-sqlglot
branch
from
1e1ff48 to
685d66f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I wanted to tackle #11310 by adding a new class method for Schema.
I wrote a unit test that tries a ton of types (it may be overkill), but it seems to be working and
my manual testing has been successful too.
Should this also support a dialect argument? I wasn't sure if this should be a requirement for
the end user (It's defaulting to duckdb now to map the types).
Issues (partially) closed
#11310 - I can tackle renaming to_sqlglot to to_sqlglot_columns_definition and
change the behavior of the former in a separate PR.