Skip to content

docs(api): indicate that re_search need only match part of a string #10402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

docs(api): indicate that re_search need only match part of a string #10402

merged 1 commit into from
Oct 31, 2024

Conversation

NickCrews
Copy link
Contributor

I am never sure if the pattern needs to match the ENTIRE string, or only part of it. This makes that clear.

cpcloud
cpcloud approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpcloud cpcloud added the docs Documentation related issues or PRs label Oct 31, 2024
@cpcloud cpcloud changed the title docs: improve re_search docstring docs(api): indicate that re_search need only match part of a string Oct 31, 2024
@cpcloud cpcloud added this to the 10.0 milestone Oct 31, 2024
@cpcloud cpcloud merged commit 78d88a5 into ibis-project:main Oct 31, 2024
80 checks passed
@cpcloud cpcloud added the ux User experience related issues label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
docs Documentation related issues or PRs ux User experience related issues
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@NickCrews @cpcloud