Skip to content

feat(ux): include type of bad value in SignatureValidationError #10988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

NickCrews
Copy link
Contributor

While trying to do some refactoring in ibis, I was getting

SignatureValidationError: ArrayContains(┏━━━━━━━━━━━━━━━━┓
┃ arr            ┃
┡━━━━━━━━━━━━━━━━┩
│ array<int64>   │
├────────────────┤
│ [1, 2, ... +1] │
│ [2, 3, ... +1] │
└────────────────┘, _.x) has failed due to the following errors:
  `other`: _.x is not coercible to a Value

Expected signature: ArrayContains(arg: Value[Array, DataShape], other: Value)

and this was very confusign to me, because it looks like _.x is a Deferred, which should be coercible. But actually it was a deferred.BinaryOperator. Now this actually will show this in the error message, making it easier to debug.

@github-actions github-actions bot added the tests Issues or PRs related to tests label Mar 12, 2025
@cpcloud cpcloud changed the title feat: include type of bad value in SignatureValidationError feat(ux): include type of bad value in SignatureValidationError Mar 14, 2025
@cpcloud cpcloud merged commit a706afa into ibis-project:main Mar 14, 2025
107 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants