feat(ux): include type of bad value in SignatureValidationError (#10988)

Author: NickCrews

ibis/common/annotations.py

@@ -88,7 +88,7 @@ def __str__(self):
 
         errors = ""
         for name, value, pattern in self.errors:
-            errors += f"\n  `{name}`: {value!r} is not {pattern.describe()}"
+            errors += f"\n  `{name}`: {value!r} of type {type(value)} is not {pattern.describe()}"
 
         sig = f"{self.func.__name__}{self.sig}"
         cause = str(self.__cause__) if self.__cause__ else ""

ibis/common/tests/snapshots/test_grounds/test_error_message/error_message.txt

@@ -1,8 +1,8 @@
 Example('1', '2', '3', '4', '5', []) has failed due to the following errors:
-  `a`: '1' is not an int
-  `b`: '2' is not an int
-  `d`: '4' is not either None or a float
-  `e`: '5' is not a tuple of ints
-  `f`: [] is not coercible to an int
+  `a`: '1' of type <class 'str'> is not an int
+  `b`: '2' of type <class 'str'> is not an int
+  `d`: '4' of type <class 'str'> is not either None or a float
+  `e`: '5' of type <class 'str'> is not a tuple of ints
+  `f`: [] of type <class 'list'> is not coercible to an int
 
 Expected signature: Example(a: int, b: int = 0, c: str = 'foo', d: Optional[float] = None, e: tuple = (1, 2, 3), f: CoercedTo[int] = 1)

ibis/common/tests/snapshots/test_grounds/test_error_message/error_message_py311.txt

@@ -1,8 +1,8 @@
 Example('1', '2', '3', '4', '5', []) has failed due to the following errors:
-  `a`: '1' is not an int
-  `b`: '2' is not an int
-  `d`: '4' is not either None or a float
-  `e`: '5' is not a tuple of ints
-  `f`: [] is not coercible to an int
+  `a`: '1' of type <class 'str'> is not an int
+  `b`: '2' of type <class 'str'> is not an int
+  `d`: '4' of type <class 'str'> is not either None or a float
+  `e`: '5' of type <class 'str'> is not a tuple of ints
+  `f`: [] of type <class 'list'> is not coercible to an int
 
 Expected signature: Example(a: int, b: int = 0, c: str = 'foo', d: Optional[float] = None, e: tuple[int, ...] = (1, 2, 3), f: CoercedTo[int] = 1)

ibis/expr/operations/tests/snapshots/test_generic/test_error_message_when_constructing_literal/call4-invalid_dtype/invalid_dtype.txt

@@ -1,4 +1,4 @@
 Literal(1, 4) has failed due to the following errors:
-  `dtype`: 4 is not coercible to a DataType
+  `dtype`: 4 of type <class 'int'> is not coercible to a DataType
 
 Expected signature: Literal(value: Annotated[Any, Not(pattern=InstanceOf(type=<class 'Deferred'>))], dtype: DataType)