feat(api): add name kwarg to Table.value_counts()
#10361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
NickCrews
changed the title
name kwarg to Table.value_counts()
This now matches Column.value_counts() The doctest can act as a test I figure.
NickCrews
force-pushed
the
value-counts-name
branch
from
9044eb0 to
fd70454
Compare
cpcloud
requested changes
Oct 24, 2024
NickCrews
force-pushed
the
value-counts-name
branch
from
df9f180 to
31dd34e
Compare
Co-authored-by: Phillip Cloud <[email protected]>
NickCrews
force-pushed
the
value-counts-name
branch
from
31dd34e to
a891e29
Compare
cpcloud
approved these changes
Oct 26, 2024
cpcloud
changed the title
name kwarg to Table.value_counts()name kwarg to Table.value_counts()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now matches Column.value_counts()
The doctest can act as a test I figure.