Skip to content

Commit 31dd34e

Browse files
NickCrewscpcloud
andcommitted
chore: apply suggestions from code review
Co-authored-by: Phillip Cloud <[email protected]>
1 parent fd70454 commit 31dd34e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

ibis/expr/types/relations.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4625,7 +4625,8 @@ def value_counts(self, *, name: str | None = None) -> ir.Table:
46254625
└───────┴───────────┴───────────────────┘
46264626
"""
46274627
columns = self.columns
4628-
name = name or "_".join(columns) + "_count"
4628+
if name is None:
4629+
name = "_".join(columns) + "_count"
46294630
return self.group_by(columns).agg(lambda t: t.count().name(name))
46304631

46314632
def unnest(

0 commit comments

Comments
 (0)