Configuration improvements #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
Environment is not always ideal for keeping secrets. For code that gets deployed on servers or in containers - obviously. But this tool will running on the users personal device in almost all cases. Env vars are much more exposed to 3rd parties and can be read by anything executed from your shell or its forks. That includes random postinstall scripts in that 10GB
node_modulesfolder.There are workarounds, like aliasing the
qcommand toexport ... && q, but supporting inline config and making env usage explicit is still an improvement. Inline config would be a better default, but for now I just wanted to add flexibility without breaking backwards compatibility.