Fix 0.4.0 compilation problem

[pelov]

Description

This is a quick fix for #275 mostly by looking at how other projects use the prometheus/exporter-toolkit to parse the kingping flags.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested that the --web.listen-address flag is working but haven't tested the --web.config.

[vutkin]

Hi @pelov, thanks for contribution, but you need adjust README.md as well in this PR.

[pelov]

Hi @pelov, thanks for contribution, but you need adjust README.md as well in this PR.

What needs to be fixed in the README.md file? Nothing has changed in the command line options.

[vutkin]

What I see:

• now LISTEN_ADDRESS could not be configured via env var;
• --web.config don't needed anymore (here I am not sure)?

[pelov]

The options that you see deleted in the diff (--web.listen-address and --web.config) are now added by the call to webflag.AddFlags. See https://github.com/prometheus/exporter-toolkit/blob/master/web/kingpinflag/flag.go.

I looked more carefully and noticed that --web.config is now renamed to --web.config.file. In addition, there is a new option --web.systemd-socket.

I updated the README.md file to reflect these changes.

I also tested the --web.config.file option and it seems to be working, i.e. starts listening on https instead of http.

[vutkin]

Could you please update release version as well?
https://github.com/iamseth/oracledb_exporter/blob/master/Makefile#L6
Please set it to 0.4.1

[vutkin]

Thanks, let's wait for github-action run.

[Yannig]

Hi people !

That look awesome and thanks for the contribution.

[vutkin]

@Yannig could you please rerun next pipeline https://github.com/iamseth/oracledb_exporter/actions/runs/4069569816?

[vutkin]

Hi @pelov, could you please do a rebase of fork repo from master and do a rebase from master for this PR (something like git rebase origin/master)?
It should be checked with pipeline but current version uses old broken one.

TIA.

[vutkin]

Good evening @Yannig , could you please approve a pipeline run https://github.com/iamseth/oracledb_exporter/actions/runs/4087340850?

[vutkin]

Hi @pelov, could you please do a rebase again? Sorry for this. But pipeline was broken.

[vutkin]

Hey @Yannig , could you please approve a github run https://github.com/iamseth/oracledb_exporter/actions/runs/4098822304?