-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Unable to compile shadowJar and other issues #3602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yeah R8 is having some issues and stripping way more than it should - blocker for 2.10.x at the moment. |
Broke here for context, but I'm not reverting to force myself to fix it before a release - e69ecb5 |
I dug into this - it appears the old old xmlpull library is violating spec for loaders, so R8 is stripping it out.
So two classes comma delimited, but spec says it must be newline delimited. I was hoping I could just upgrade this package, but its been dead for a decade.
https://docs.oracle.com/javase/6/docs/technotes/guides/jar/jar.html#Service%20Provider |
Not sure what change caused this breakage, but here it goes.
Command:
./gradlew build shadowJar proguard release
Fails with error:
When commenting out this line in brut.apktool\apktool-cli\build.gradle.kts:
Then the JAR compiles fine, but when trying to use it, none of the XML files can be decompiled and ends with an error:
When manually adding META-INF/services/org.xmlpull.v1.XmlPullParserFactory extracted from a previous Apktool JAR to the build JAR, all works fine.
Also, when building without "release", the output is apktool-v2.9.2-48-6b986e9a-SNAPSHOT.jar, not 2.10.0.
Quite a whole lot of mess.
The text was updated successfully, but these errors were encountered: