Skip to content

Update PDF.js to v2.14.137 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Update PDF.js to v2.14.137 #26

merged 2 commits into from
Apr 7, 2022

Conversation

robertknight
Copy link
Member

See hypothesis/via#720 and hypothesis/browser-extension#799. Like those two PRs, this one both updates PDF.js and updates the tools/update-pdfjs script to auto-commit the changes and revise the documentation.

Following similar changes in our other projects, auto-commit PDF.js
changes as part of the `tools/update-pdfjs` script.

Also update the documentation to be correct for this project. Some of
the instructions had not been updated since the script was copied from
the hypothesis/browser-extension repository.
Update PDF.js using tools/update-pdfjs.
Copy link
Contributor

@lyzadanger lyzadanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, in that it is equivalent to changes in the client project. If there's any additional verification/testing I should do, give me a shout.

@robertknight robertknight merged commit 6a6adc9 into master Apr 7, 2022
@robertknight robertknight deleted the update-pdfjs-apr-2022 branch April 7, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants