Warn when closing tab if there is an unsaved, non-empty draft #7083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7083 +/- ##
=======================================
Coverage 99.38% 99.38%
=======================================
Files 277 278 +1
Lines 11273 11291 +18
Branches 2719 2722 +3
=======================================
+ Hits 11204 11222 +18
Misses 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Copy the `useUnsavedChanges` hook from the h repository and use it in AnnotationEditor to enable a warning if the user tries to close the tab while there is a non-empty draft. In the process, fix a bug where `returnValue` was set to an empty string when according to MDN, it must be set to a truthy value. Without this change, the hook works in Chrome but not Firefox. This change works in Chrome and Firefox, but not Safari. In Safari, the tab closes even when the `beforeunload` handler is active. Part of hypothesis/support#59.
robertknight
force-pushed
the
unsaved-draft-warning
branch
from
28d0099 to
341619b
Compare
robertknight
commented
May 16, 2025
| @@ -0,0 +1,55 @@ | |||
| import { useEffect } from 'preact/hooks'; | |||
There was a problem hiding this comment.
Next week I will look at upstreaming this into the frontend-shared library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the
useUnsavedChangeshook from the h repository and use it in AnnotationEditor to enable a warning if the user tries to close the tab while there is a non-empty draft. In the process, fix a bug wherereturnValuewas set to an empty string when according to MDN, it must be set to a truthy value. Without this change, the hook works in Chrome but not Firefox.This change works in Chrome and Firefox, but not Safari. In Safari, the tab closes even when the
beforeunloadhandler is active.Part of https://github.com/hypothesis/support/issues/59.
Testing: