Skip to content

Update PDF.js to v2.14.137 #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Update PDF.js to v2.14.137 #4396

merged 2 commits into from
Apr 7, 2022

Conversation

robertknight
Copy link
Member

See hypothesis/browser-extension#799 and similar PRs in the via and pdf.js-hypothesis repos.

Simplify update process slightly and standardize commit message by
creating the commit as part of the update-pdfjs script.
Update PDF.js using ./scripts/update-pdfjs.
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #4396 (84803c2) into master (d80d8e9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4396   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         228      228           
  Lines        8651     8651           
  Branches     2040     2040           
=======================================
  Hits         8579     8579           
  Misses         72       72           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@lyzadanger lyzadanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 This works, as in, the version of PDFjs is upgraded and works with the test PDFs in the dev-server.

Logged to console on http://localhost:3000/pdf/budlong before these changes:

PDF 7c34b83eb2ff117297427d3c8eb2465b [1.4 Skia/PDF m84 / Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.105 Safari/537.36] (PDF.js: 2.11.213)

and after:

PDF 7c34b83eb2ff117297427d3c8eb2465b [1.4 Skia/PDF m84 / Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.105 Safari/537.36] (PDF.js: 2.14.137)

@robertknight robertknight merged commit df50462 into master Apr 7, 2022
@robertknight robertknight deleted the update-pdfjs-apr-2022 branch April 7, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants