Skip to content

Readium demo not working reliably #4153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
robertknight opened this issue Jan 31, 2022 · 4 comments
Closed
1 of 3 tasks

Readium demo not working reliably #4153

robertknight opened this issue Jan 31, 2022 · 4 comments
Labels

Comments

@robertknight
Copy link
Member

robertknight commented Jan 31, 2022

The Readium EPUB demo is not working reliably.

In Safari, selecting text in the ebook content doesn't show the Annotate / Highlight actions. There is also a spurious cross-origin access error in the browser console that doesn't affect execution.

In Chrome, the adder does appear when selecting text, but all the annotations orphan and after ~30 seconds, the following errors appear in the console:

Readium demo errors in Chrome

In Firefox the result is the same as in Chrome.

The issue in Chrome and Firefox looks the issue described and resolved in #4144.


Update 2022-02-07:

The initial issue described in Chrome/Firefox was fixed, but there are still three issues present:

@robertknight
Copy link
Member Author

#4144 is now resolved, and some of the annotations now anchor in Chrome / Firefox. Some others do not however. Comparing the JSON data of the annotations which anchor vs those that do not, it looks like the annotations have different associated URLs. It looks like those annotations whose primary URL matches the <link rel="canonical>" URL of the book content anchor, but others do not. I think what is happening here relates to the limitation described in #4131 where annotations are not sent to a non-main frame unless the annotation's URL exactly matches the current frame URL.

@robertknight
Copy link
Member Author

Additional problems seen after resolving #4144:

  • The problem in Safari where selecting text does not show the Annotate/Highlight buttons persists
  • In Chrome/Firefox, highlights are missing for some annotations, even though they apparently anchored. For example this annotation:

Corlears hook anchor

See that the text "Corlears hook" is not highlighted on the left, though it appears to have anchored.

@robertknight
Copy link
Member Author

The issue with the adder not appearing in Safari was a general issue for XHTML documents. It was fixed by #4353.

@robertknight
Copy link
Member Author

See #4283 (comment).

@robertknight robertknight closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants