Largish changes to in-RAM temp buckets #453
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default for ram < 256MB.
Conflicts: src/freenet/l10n/freenet.l10n.en.properties src/freenet/node/NodeClientCore.java src/freenet/support/io/TempBucketFactory.java test/freenet/store/SlashdotStoreTest.java test/freenet/support/io/TempBucketTest.java
When it is migrated to disk, it will be removed from the queue. Don't put it back there!
|
I'm not sure I get why it's better than the current behaviour. Why would we want to always migrate stuff to disk? IMHO if there's no memory pressure it's just wasted disk IO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes here:
(On next we migrate buckets to disk in order of creation when we run out of disk space)
For consideration. Maybe we want to keep only some of this. This needs testing - porting it forward to next was fairly involved. It should improve performance on average new nodes; I believe I tested it quite a bit at the time, but there have been significant changes since then. There may be lock contention issues, or even full blown deadlocks etc; this is for discussion, not for immediate inclusion.