Skip to content

feature: try to unify all versions to one #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Anmol1696
Copy link
Collaborator

No description provided.

@Anmol1696 Anmol1696 requested a review from Copilot May 19, 2025 13:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR unifies the version numbers across the repository to 3.7.0 to maintain consistency and simplify version management.

  • Updated Chart.yaml to reflect the new version.
  • Introduced a version synchronization script (sync-version.sh) that updates version strings in various files.
  • Updated package.json files and added a VERSION file with the unified version.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
starship/charts/devnet/Chart.yaml Updated chart version to 3.7.0.
scripts/sync-version.sh Added a script to sync version numbers across files.
clients/js/packages/starshipjs/package.json Updated package version to 3.7.0.
clients/js/package.json Updated version and modified publish commands for consistency.
VERSION Introduced VERSION file with version 3.7.0.

Comment on lines +16 to +26
# Update Chart.yaml
echo "Updating Chart.yaml..."
sed -i '' "s/^version: .*/version: $version/" starship/charts/devnet/Chart.yaml

# Update root package.json
echo "Updating root package.json..."
sed -i '' "s/\"version\": \".*\"/\"version\": \"$version\"/" clients/js/package.json

# Update all package.json files in packages
echo "Updating package.json files in packages..."
find clients/js/packages -name "package.json" -exec sed -i '' "s/\"version\": \".*\"/\"version\": \"$version\"/" {} \;
Copy link
Preview

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The in-place sed command using 'sed -i ''' may work on macOS but can cause issues on Linux (GNU sed) which uses a different syntax. Consider adding conditional handling or documentation to ensure cross-platform compatibility.

Suggested change
# Update Chart.yaml
echo "Updating Chart.yaml..."
sed -i '' "s/^version: .*/version: $version/" starship/charts/devnet/Chart.yaml
# Update root package.json
echo "Updating root package.json..."
sed -i '' "s/\"version\": \".*\"/\"version\": \"$version\"/" clients/js/package.json
# Update all package.json files in packages
echo "Updating package.json files in packages..."
find clients/js/packages -name "package.json" -exec sed -i '' "s/\"version\": \".*\"/\"version\": \"$version\"/" {} \;
# Detect OS and set sed command
local sed_command
if [[ "$(uname)" == "Darwin" ]]; then
sed_command="sed -i ''"
else
sed_command="sed -i"
fi
# Update Chart.yaml
echo "Updating Chart.yaml..."
$sed_command "s/^version: .*/version: $version/" starship/charts/devnet/Chart.yaml
# Update root package.json
echo "Updating root package.json..."
$sed_command "s/\"version\": \".*\"/\"version\": \"$version\"/" clients/js/package.json
# Update all package.json files in packages
echo "Updating package.json files in packages..."
find clients/js/packages -name "package.json" -exec $sed_command "s/\"version\": \".*\"/\"version\": \"$version\"/" {} \;

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant