You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For parsing the config file that we provide Starship users, there are already 3 internal implementations of the same. Which are:
clients/go/client/config.go
cmd/starship/
tests/e2e/config.go
Proposal
Unify the configs to be part of a common pkg or something. Note can just be part of the starship client itself, but would have to live outside the cmd/ dir.
Option 1
With #229, we can have a dedicated config pkg available at: pkg/config/helm.go. Inorder to make it independently importatble might have to create a go.mod for it seperately itself.
Option 2
Create a proto from the values.schema.json, and use the proto complilation as config definations. Can be available at types/ dir at root.