Skip to content

[INDY-1058] Get rid of Registry-based pools #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Mar 21, 2018

Conversation

ArtObr
Copy link
Contributor

@ArtObr ArtObr commented Mar 13, 2018

Get rid of Registry-based pools ( nodeSet)

@ArtObr ArtObr changed the title [INDY-1058] Get rid of Registry-based pools [INDY-1058] Get rid of Registry-based pools [skip ci] Mar 13, 2018
ArtObr added 19 commits March 13, 2018 19:29
Signed-off-by: ArtObr <[email protected]>
Signed-off-by: ArtObr <[email protected]>
Signed-off-by: ArtObr <[email protected]>
ArtObr added 2 commits March 20, 2018 13:34
Signed-off-by: ArtObr <[email protected]>
Signed-off-by: ArtObr <[email protected]>
@ArtObr ArtObr changed the title [INDY-1058] Get rid of Registry-based pools [skip ci] [INDY-1058] Get rid of Registry-based pools Mar 20, 2018
@ArtObr
Copy link
Contributor Author

ArtObr commented Mar 21, 2018

Test this please

ArtObr added 2 commits March 21, 2018 08:32
…dy-plenum into indy-sdk-integration/INDY-1058

Signed-off-by: ArtObr <[email protected]>
@ArtObr
Copy link
Contributor Author

ArtObr commented Mar 21, 2018

Test this please

@@ -225,15 +225,16 @@ def chk():


# noinspection PyIncorrectDocstring
def testReplyMatchesRequest(looper, nodeSet, client_tdir, up):
@pytest.mark.skip('Unskip and complete this test while sdk integration')
def testReplyMatchesRequest(looper, txnPoolNodeSet, client_tdir):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the test

@@ -293,9 +294,10 @@ def makeClient(id):
assert replies[0] == sentAmount


def testReplyReceivedOnlyByClientWhoSentRequest(looper, nodeSet, client_tdir,
@pytest.mark.skip('Unskip and complete this test while sdk integration')
def testReplyReceivedOnlyByClientWhoSentRequest(looper, txnPoolNodeSet, client_tdir,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the test

@@ -6,13 +6,15 @@
from plenum.test.test_client import TestClient


@pytest.mark.skip('Wait for decision')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the test

def testMerkleProofForFirstLeaf(client1: TestClient, replied1):
replies = client1.getRepliesFromAllNodes(*replied1.key).values()
assert Client.verifyMerkleProof(*replies)


@pytest.mark.skip('Wait for decision')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the test

ArtObr added 3 commits March 21, 2018 10:49
Signed-off-by: ArtObr <[email protected]>
Signed-off-by: ArtObr <[email protected]>
@dsurnin
Copy link
Contributor

dsurnin commented Mar 21, 2018

Test this please

@ashcherbakov ashcherbakov merged commit 1fffcf4 into hyperledger:master Mar 21, 2018
lampkin-diet pushed a commit to lampkin-diet/indy-plenum that referenced this pull request Mar 22, 2018
* Initial test integration

Signed-off-by: ArtObr <[email protected]>

* Two more files done

Signed-off-by: ArtObr <[email protected]>

* new test

Signed-off-by: ArtObr <[email protected]>

* 4 more folders done

Signed-off-by: ArtObr <[email protected]>

* two more files

Signed-off-by: ArtObr <[email protected]>

* some changes

Signed-off-by: ArtObr <[email protected]>

* More tests integrated. Problems: validator functions of client in test_state_proof; problem with wrong bls keys

Signed-off-by: ArtObr <[email protected]>

* Initial commit

Signed-off-by: ArtObr <[email protected]>

* Script fix. bls validation fix

Signed-off-by: ArtObr <[email protected]>

* more changes

Signed-off-by: ArtObr <[email protected]>

* little fix

Signed-off-by: ArtObr <[email protected]>

* Fix for bls validation tests. Not done: update_incorrect test and state_proof test

Signed-off-by: ArtObr <[email protected]>

* Only state_proof test left

Signed-off-by: ArtObr <[email protected]>

* Tests integration done

Signed-off-by: ArtObr <[email protected]>

* Deletion of Client1Connected. More test fix

Signed-off-by: ArtObr <[email protected]>

* Import deletion. flake8 error fix.

Signed-off-by: ArtObr <[email protected]>

* More changes to txnPoolNodeSet

Signed-off-by: ArtObr <[email protected]>

* Changes in tests

Signed-off-by: ArtObr <[email protected]>

* Remove pf TestNodeSet. Change of helper methods. Part 1.

Signed-off-by: ArtObr <[email protected]>

* Remove TestNodeSet from helper. part 2

Signed-off-by: ArtObr <[email protected]>

* More tests integrated

Signed-off-by: ArtObr <[email protected]>

* Functions fixes.

Signed-off-by: ArtObr <[email protected]>

* Fix for genesis txns

Signed-off-by: ArtObr <[email protected]>

* More tests integrated

Signed-off-by: ArtObr <[email protected]>

* primary_selection dependency fix

Signed-off-by: ArtObr <[email protected]>

* Fixture fix for view_change

Signed-off-by: ArtObr <[email protected]>

* View change test fix

Signed-off-by: ArtObr <[email protected]>

* Skips for merkle proof tests

Signed-off-by: ArtObr <[email protected]>

* Skips for merkle proof tests

Signed-off-by: ArtObr <[email protected]>

* Review changes

Signed-off-by: ArtObr <[email protected]>

* Review changes

Signed-off-by: ArtObr <[email protected]>
lampkin-diet pushed a commit to lampkin-diet/indy-plenum that referenced this pull request Apr 9, 2018
* Initial test integration

Signed-off-by: ArtObr <[email protected]>

* Two more files done

Signed-off-by: ArtObr <[email protected]>

* new test

Signed-off-by: ArtObr <[email protected]>

* 4 more folders done

Signed-off-by: ArtObr <[email protected]>

* two more files

Signed-off-by: ArtObr <[email protected]>

* some changes

Signed-off-by: ArtObr <[email protected]>

* More tests integrated. Problems: validator functions of client in test_state_proof; problem with wrong bls keys

Signed-off-by: ArtObr <[email protected]>

* Initial commit

Signed-off-by: ArtObr <[email protected]>

* Script fix. bls validation fix

Signed-off-by: ArtObr <[email protected]>

* more changes

Signed-off-by: ArtObr <[email protected]>

* little fix

Signed-off-by: ArtObr <[email protected]>

* Fix for bls validation tests. Not done: update_incorrect test and state_proof test

Signed-off-by: ArtObr <[email protected]>

* Only state_proof test left

Signed-off-by: ArtObr <[email protected]>

* Tests integration done

Signed-off-by: ArtObr <[email protected]>

* Deletion of Client1Connected. More test fix

Signed-off-by: ArtObr <[email protected]>

* Import deletion. flake8 error fix.

Signed-off-by: ArtObr <[email protected]>

* More changes to txnPoolNodeSet

Signed-off-by: ArtObr <[email protected]>

* Changes in tests

Signed-off-by: ArtObr <[email protected]>

* Remove pf TestNodeSet. Change of helper methods. Part 1.

Signed-off-by: ArtObr <[email protected]>

* Remove TestNodeSet from helper. part 2

Signed-off-by: ArtObr <[email protected]>

* More tests integrated

Signed-off-by: ArtObr <[email protected]>

* Functions fixes.

Signed-off-by: ArtObr <[email protected]>

* Fix for genesis txns

Signed-off-by: ArtObr <[email protected]>

* More tests integrated

Signed-off-by: ArtObr <[email protected]>

* primary_selection dependency fix

Signed-off-by: ArtObr <[email protected]>

* Fixture fix for view_change

Signed-off-by: ArtObr <[email protected]>

* View change test fix

Signed-off-by: ArtObr <[email protected]>

* Skips for merkle proof tests

Signed-off-by: ArtObr <[email protected]>

* Skips for merkle proof tests

Signed-off-by: ArtObr <[email protected]>

* Review changes

Signed-off-by: ArtObr <[email protected]>

* Review changes

Signed-off-by: ArtObr <[email protected]>
lampkin-diet pushed a commit to lampkin-diet/indy-plenum that referenced this pull request Apr 10, 2018
* Initial test integration

Signed-off-by: ArtObr <[email protected]>

* Two more files done

Signed-off-by: ArtObr <[email protected]>

* new test

Signed-off-by: ArtObr <[email protected]>

* 4 more folders done

Signed-off-by: ArtObr <[email protected]>

* two more files

Signed-off-by: ArtObr <[email protected]>

* some changes

Signed-off-by: ArtObr <[email protected]>

* More tests integrated. Problems: validator functions of client in test_state_proof; problem with wrong bls keys

Signed-off-by: ArtObr <[email protected]>

* Initial commit

Signed-off-by: ArtObr <[email protected]>

* Script fix. bls validation fix

Signed-off-by: ArtObr <[email protected]>

* more changes

Signed-off-by: ArtObr <[email protected]>

* little fix

Signed-off-by: ArtObr <[email protected]>

* Fix for bls validation tests. Not done: update_incorrect test and state_proof test

Signed-off-by: ArtObr <[email protected]>

* Only state_proof test left

Signed-off-by: ArtObr <[email protected]>

* Tests integration done

Signed-off-by: ArtObr <[email protected]>

* Deletion of Client1Connected. More test fix

Signed-off-by: ArtObr <[email protected]>

* Import deletion. flake8 error fix.

Signed-off-by: ArtObr <[email protected]>

* More changes to txnPoolNodeSet

Signed-off-by: ArtObr <[email protected]>

* Changes in tests

Signed-off-by: ArtObr <[email protected]>

* Remove pf TestNodeSet. Change of helper methods. Part 1.

Signed-off-by: ArtObr <[email protected]>

* Remove TestNodeSet from helper. part 2

Signed-off-by: ArtObr <[email protected]>

* More tests integrated

Signed-off-by: ArtObr <[email protected]>

* Functions fixes.

Signed-off-by: ArtObr <[email protected]>

* Fix for genesis txns

Signed-off-by: ArtObr <[email protected]>

* More tests integrated

Signed-off-by: ArtObr <[email protected]>

* primary_selection dependency fix

Signed-off-by: ArtObr <[email protected]>

* Fixture fix for view_change

Signed-off-by: ArtObr <[email protected]>

* View change test fix

Signed-off-by: ArtObr <[email protected]>

* Skips for merkle proof tests

Signed-off-by: ArtObr <[email protected]>

* Skips for merkle proof tests

Signed-off-by: ArtObr <[email protected]>

* Review changes

Signed-off-by: ArtObr <[email protected]>

* Review changes

Signed-off-by: ArtObr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants