Skip to content

INDY-580: Improve packaging before supporting CentOS #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2017
Merged

INDY-580: Improve packaging before supporting CentOS #412

merged 2 commits into from
Oct 25, 2017

Conversation

btlogy
Copy link
Contributor

@btlogy btlogy commented Oct 11, 2017

  • Work around missing "docker volume rm --force" option in older API (< 1.25). So it also works with docker 1.12 provided with CentOS 7 (should not hurt).
  • Quote shell variables to support space in paths (always good).
  • Support parallel docker builds by adding suffix to volumes in case of multi-branch pipeline (should not change anything for single-branch).

REM: See other PR's for similar improvements in other indy repos (i.e.: for indy-node).

Benoit Donneaux added 2 commits October 11, 2017 18:00
Prepare support for CentOS
7dea9c7 
* support for older Docker
* quotes to support spaces in dir.
* support multi-branch PL with Docker volume suffixes
 

Signed-off-by: Benoit Donneaux <[email protected]>
- add missing new argument for Docker volume
23300bc 
Signed-off-by: Benoit Donneaux <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Oct 11, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@andkononykhin
Copy link
Contributor

test this please

@evernym-ci
Copy link
Contributor

Can one of the admins verify this patch?

@andkononykhin
Copy link
Contributor

test this please

4 similar comments
@andkononykhin
Copy link
Contributor

test this please

@andkononykhin
Copy link
Contributor

test this please

@andkononykhin
Copy link
Contributor

test this please

@andkononykhin
Copy link
Contributor

test this please

@andkononykhin andkononykhin merged commit 6da5258 into hyperledger:master Oct 25, 2017
@btlogy btlogy deleted the improv branch December 4, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andkononykhin andkononykhin andkononykhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@btlogy @CLAassistant @andkononykhin @evernym-ci