Skip to content

INDY-1340: go to next view on timeuout for PBFT View Change Service #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 13, 2019
Merged

INDY-1340: go to next view on timeuout for PBFT View Change Service #1330

merged 6 commits into from
Sep 13, 2019

Conversation

ashcherbakov
Copy link
Contributor

  • go to next view on timeuout for PBFT View Change Service
  • fix unstash after view change is finished

Toktar
Toktar reviewed Sep 13, 2019
View reviewed changes
plenum/server/consensus/view_change_service.py
if self._resend_inst_change_timer is not None:
self._resend_inst_change_timer.stop()
self._resend_inst_change_timer = \
RepeatingTimer(self._timer,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think will be better in a future use one RepeatingTimer without recreating it.

Toktar
Toktar previously approved these changes Sep 13, 2019
View reviewed changes
@ashcherbakov ashcherbakov merged commit 9ae0e15 into hyperledger:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toktar Toktar Toktar approved these changes

@lampkin-diet lampkin-diet Awaiting requested review from lampkin-diet

@skhoroshavin skhoroshavin Awaiting requested review from skhoroshavin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashcherbakov @Toktar