INDY-1340: pp_view_no (original view no) support #1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashcherbakov
commented
Sep 6, 2019
ashcherbakov
commented
- Added pp_view_no to every BatchID
- Added (optional) pp_view_no to PrePrepares
- This is the viewNo where the PrePrepare associated with the BatchID has been applied first time (so persisted in the audit ledger)
- added new tests and fixed existing ones
- added the field - fixed tests - added new tests Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
…nto indy_1340_process_new_view Signed-off-by: ashcherbakov <[email protected]> # Conflicts: # plenum/test/consensus/view_change/test_view_change_msg_creation.py
Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
ashcherbakov
requested review from
lampkin-diet,
skhoroshavin and
Toktar
as code owners
Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
Signed-off-by: ashcherbakov <[email protected]>
ashcherbakov
changed the title
lampkin-diet
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.