INDY-2215: add re-ask LedgerStatuses for the init catchup #1305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: toktar <[email protected]>
|
Test this please |
1 similar comment
|
Test this please |
skhoroshavin
previously approved these changes
Aug 26, 2019
Signed-off-by: toktar <[email protected]>
Signed-off-by: toktar <[email protected]>
|
Test this please |
Signed-off-by: toktar <[email protected]>
Signed-off-by: toktar <[email protected]>
ashcherbakov
approved these changes
Aug 26, 2019
skhoroshavin
approved these changes
Aug 26, 2019
| self._callback = wrapped_callback | ||
| self._active = False | ||
| if active: | ||
| self.start() | ||
|
|
||
| def start(self): | ||
| if self._active: | ||
| if self._active or not self._interval: |
There was a problem hiding this comment.
Suggested change
| if self._active or not self._interval: | |
| if self._active or self._interval is None: |
There was a problem hiding this comment.
In this case we will not catch interval = 0
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Aug 28, 2019
INDY-2215: add re-ask LedgerStatuses for the init catchup
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Aug 28, 2019
INDY-2215: add re-ask LedgerStatuses for the init catchup Signed-off-by: Andrew Nikitin <[email protected]>
Toktar
added a commit
to Toktar/indy-plenum
that referenced
this pull request
Mar 1, 2021
INDY-2215: add re-ask LedgerStatuses for the init catchup Signed-off-by: Andrew Nikitin <[email protected]>
Toktar
added a commit
to Toktar/indy-plenum
that referenced
this pull request
Mar 1, 2021
INDY-2215: add re-ask LedgerStatuses for the init catchup Signed-off-by: Andrew Nikitin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: toktar [email protected]