Skip to content

Remove privacy and onchain permissioning content #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Jul 26, 2025

Description

Remove and update all privacy and onchain permissioning related content across the docs.

Issue(s) fixed

Fixes #1813
Fixes #1814

Preview

https://besu-docs-mp0lp1fu7-hyperledger.vercel.app/private-networks

@alexandratran alexandratran requested a review from a team as a code owner July 26, 2025 04:02
Copy link

vercel bot commented Jul 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 2:00am

@macfarla
Copy link
Contributor

@alexandratran there's an image here that still shows local + onchain permissioning, can that be updated - I think if you

  • remove the "check onchain permissions" text from the diagram,
  • instead of "Onchain and local", change it to "Local permissions checked" or "Local permissions applied"
  • add something in the paragraph above it to say that the diagram shows where local rules are checked

then the diagram is still useful to show that when blocks come from other nodes, those local rules are not checked. On the other hand, you could say that with words and nuke the diagram.

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove PRIV and EEA from this list of APIs- might also be under websockets
https://besu-docs-rnbr8w9as-hyperledger.vercel.app/public-networks/reference/cli/options#rpc-http-api

also there is some deleted content on this page that is unrelated to privacy/permissioning docs/private-networks/how-to/configure/consensus/add-validators-without-voting.md

@macfarla
Copy link
Contributor

looks good overall. couple of changes requested

Signed-off-by: Alexandra Tran <[email protected]>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just this diagram needs privacy removed - https://besu-docs-5ho4n9fb6-hyperledger.vercel.app/private-networks

@macfarla
Copy link
Contributor

one more nit: can you replace eth_getWork in no-auth and also rpc-http-no-auth with debug_traceCall

Signed-off-by: Alexandra Tran <[email protected]>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexandratran alexandratran merged commit e1c9fb8 into hyperledger:main Jul 29, 2025
10 checks passed
@alexandratran alexandratran deleted the 1813-1814-remove-permissioning-privacy branch July 29, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove privacy / private transactions Remove onchain permissioning
3 participants