-
Notifications
You must be signed in to change notification settings - Fork 130
Remove privacy and onchain permissioning content #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove privacy and onchain permissioning content #1833
Conversation
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@alexandratran there's an image here that still shows local + onchain permissioning, can that be updated - I think if you
then the diagram is still useful to show that when blocks come from other nodes, those local rules are not checked. On the other hand, you could say that with words and nuke the diagram. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove PRIV and EEA from this list of APIs- might also be under websockets
https://besu-docs-rnbr8w9as-hyperledger.vercel.app/public-networks/reference/cli/options#rpc-http-api
also there is some deleted content on this page that is unrelated to privacy/permissioning docs/private-networks/how-to/configure/consensus/add-validators-without-voting.md
docs/private-networks/how-to/configure/consensus/add-validators-without-voting.md
Show resolved
Hide resolved
looks good overall. couple of changes requested |
Signed-off-by: Alexandra Tran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just this diagram needs privacy removed - https://besu-docs-5ho4n9fb6-hyperledger.vercel.app/private-networks
one more nit: can you replace |
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Remove and update all privacy and onchain permissioning related content across the docs.
Issue(s) fixed
Fixes #1813
Fixes #1814
Preview
https://besu-docs-mp0lp1fu7-hyperledger.vercel.app/private-networks