Skip to content

Validation of identifiers within AnonCreds objects #111

Closed
@berendsliedrecht

Description

@berendsliedrecht

@TimoGlastra and I had a discussion about the validation of identifiers used within the anoncreds-rs codebase.

I created a PR hyperledger/anoncreds-rs#25 that removes the creation and internal references to the id property inside the anoncreds object and I extract to a seperate string. With this I also removed the validation of the identifier as my understanding was that any identifier is allowed.

Timo pointed me to a section in the spec, https://hyperledger.github.io/anoncreds-spec/#anoncreds-identifiers , which mentions that identifiers SHOULD be validated.

Now, @swcurran I guess the main question is, do we allow any kind of identifier and remove the validation (and change the part where we SHOULD validate) or can external identifiers only be URIs (or legacy) and we add the validation back?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions