Restored get_attribute for creddef and updated python wrapper #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebasing with main should fix the build issues |
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Gavinok
force-pushed
the
restore_anoncreds_credential_definition_get_attribute
branch
from
53d964d to
d4252a6
Compare
|
@berendsliedrecht rebased. Thanks for letting me know |
| @@ -40,25 +40,46 @@ def load(cls, value: Union[dict, str, bytes, memoryview]) -> "CredentialDefiniti | |||
| ) | |||
|
|
|||
| @property | |||
| def id(self) -> str: | |||
| def schema_id(self) -> str: | |||
There was a problem hiding this comment.
This seems to drop the "id" property accessor?
There was a problem hiding this comment.
To my knowledge there isn't actually an id field in CredentialDefinition.
https://github.com/Gavinok/anoncreds-rs/blob/main/src/data_types/cred_def.rs#L39-L48
Feel free to correct me if I am missing something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #354
I have tested this against the python wrapper and updated it to support the current values of the CredentialDefinition struct