Update schema data model #31
Conversation
| pub name: String, | ||
| pub version: String, | ||
| #[serde(rename = "attrNames")] |
There was a problem hiding this comment.
Let's wait with this one for a bit maybe. I know I created an issue to change it. But as all models are coming out to use camelCase, I think we should just jeep using camelCase here and minimize changes.
Thoughts?
There was a problem hiding this comment.
I am fine with either. I think a definitive decision would be very valuable here.
@swcurran I might have missed some of the on going discussions surrounding the spec, but is there a decision made around the anoncreds objects and which casing they use? I think I have a slight preference for snake case, but without any good reason, so either is good in my opinion. (if this needs further discussion, and there is no issue open already, I would not mind creating one).
There was a problem hiding this comment.
The reason I'm leaning to keeping it camelCase is that anoncreds objects already mostly use camelCase. The records that are registered on the indy ledger are using snake_case in some places however.
So my opinion would be to go with camelCase
berendsliedrecht
force-pushed
the
update-schema-data-model
branch
2 times, most recently
from
06d485a to
5b19944
Compare
If the discussion ends up we will use snake_case for everything then we can address in a separate PR |
Work funded by the Government of Ontario. Signed-off-by: blu3beri <[email protected]>
berendsliedrecht
force-pushed
the
update-schema-data-model
branch
from
38b4e5f to
06f2e2d
Compare
Dependent on #23, #27 and #30
closes #10
Work funded by the Government of Ontario.