Skip to content

fix: remove total number of webhook limit #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025
Merged

fix: remove total number of webhook limit #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0eca63
fix: remove total number of webhook limit
wrn14897 May 22, 2025
8268c66
Merge branch 'v2' into warren/remove-webhook-number-limit
wrn14897 May 22, 2025
488e525
docs: add changeset
wrn14897 May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fair-kangaroos-listen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hyperdx/api": patch
---

fix: remove total number of webhook limit
9 changes: 0 additions & 9 deletions packages/api/src/routers/api/webhooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,6 @@ router.post(
}
const { name, service, url, description, queryParams, headers, body } =
req.body;
const totalWebhooks = await Webhook.countDocuments({
team: teamId,
service,
});
if (totalWebhooks >= 5) {
return res.status(400).json({
message: 'You can only have 5 webhooks per team per service',
});
}
if (await Webhook.findOne({ team: teamId, service, url })) {
return res.status(400).json({
message: 'Webhook already exists',
Expand Down