Skip to content

fix: Ensure group-by works with sum metrics #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2025
Merged

fix: Ensure group-by works with sum metrics #636

merged 3 commits into from
Feb 27, 2025

Conversation

teeohhem
Copy link
Contributor

@teeohhem teeohhem commented Feb 26, 2025

Adds all available columns into the query so that we can properly apply the group by clause.

Ref: HDX-1419

Adds original attribute columns back into the query so that we can
properly apply the group by clause.

Ref: HDX-1419
Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: 7464a1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@teeohhem teeohhem marked this pull request as draft February 26, 2025 20:37
@teeohhem teeohhem marked this pull request as ready for review February 27, 2025 15:43
@kodiakhq kodiakhq bot merged commit 521793d into v2 Feb 27, 2025
4 checks passed
@kodiakhq kodiakhq bot deleted the tom/group-by-sum branch February 27, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants