Skip to content

Move to macos-14 #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move to macos-14 #1697

wants to merge 1 commit into from

Conversation

lucteo
Copy link
Contributor

@lucteo lucteo commented May 27, 2025

No description provided.

Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (75409c7) to head (b5bf648).
Report is 107 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
+ Coverage   88.39%   88.41%   +0.01%     
==========================================
  Files         382      382              
  Lines       31592    31592              
==========================================
+ Hits        27927    27931       +4     
+ Misses       3665     3661       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dabrahams
Copy link
Collaborator

I tried brew install zstd there but it was already installed. Very mysterious why it thinks the archive is invalid! We could update https://github.com/hylo-lang/llvm-build to macos14 and see if the results are more usable, but that seems like a WAG.

@dabrahams
Copy link
Collaborator

The place to make this work is on the Swifty-LLVM repo, where CI cycle times are much better.

@dabrahams
Copy link
Collaborator

It's possible you need to install gnu tar with brew. Just another WAG

@lucteo
Copy link
Contributor Author

lucteo commented May 28, 2025

The build failures seem to come from the fact that, changing the triple suffix (new: apple-darwin24.1.0), we don't have a corresponding archive in https://github.com/hylo-lang/llvm-build/releases/

@dabrahams
Copy link
Collaborator

@lucteo I think this PR is obsolete now? Or at least, the CI portion of it is.

@lucteo
Copy link
Contributor Author

lucteo commented Jun 15, 2025

@lucteo I think this PR is obsolete now? Or at least, the CI portion of it is.

Parts of it are obsolete, but I still need to make sure that the OSes we run here are the same as we use in LLVM-build. I do have patches for Durian and Swifty-LLVM that need to go first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants