-
Notifications
You must be signed in to change notification settings - Fork 59
Stdlib serialization redux #1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dabrahams
wants to merge
5
commits into
main
Choose a base branch
from
stdlib-serialization-redux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
85007bb
Add and exercise CBORCoding dependency
dabrahams 75ca308
Prepare for AST serialization.
dabrahams 6d200dd
pre-serialize and deserialize the standard library AST.
dabrahams 92df416
DRY
dabrahams c54c963
Merge remote-tracking branch 'origin/main' into stdlib-serialization-…
dabrahams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../SPMBuildToolSupport/SPMBuildToolSupport.swift |
41 changes: 41 additions & 0 deletions
41
Plugins/StandardLibraryBuilderPlugin/StandardLibraryBuilderPlugin.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
import Foundation | ||
import PackagePlugin | ||
|
||
/// The Swift Package Manager plugin that builds the standard library. | ||
@main | ||
struct StandardLibraryBuilderPlugin: SPMBuildToolPlugin { | ||
|
||
func buildCommands( | ||
context: PackagePlugin.PluginContext, target: PackagePlugin.Target | ||
) throws -> [SPMBuildCommand] { | ||
let sourceDirectory = URL(fileURLWithPath: #filePath) | ||
.deletingLastPathComponent().deletingLastPathComponent().deletingLastPathComponent() | ||
/ "StandardLibrary" / "Sources" | ||
|
||
let hostedSources = FileManager.default.enumerator( | ||
at: sourceDirectory, | ||
includingPropertiesForKeys: [.isRegularFileKey], | ||
options: [.skipsHiddenFiles, .skipsPackageDescendants])! | ||
.compactMap { $0 as? URL } | ||
.filter { $0.pathExtension == "hylo" } | ||
|
||
let freestandingRoot = (sourceDirectory / "Core").pathComponents | ||
let freestandingSources = hostedSources.filter { $0.pathComponents.starts(with: freestandingRoot) } | ||
|
||
func buildLibrary(name: String, sources: [URL]) -> SPMBuildCommand { | ||
let output = context.pluginWorkDirectory.url / (name + ".cbor") | ||
return .buildCommand( | ||
displayName: "Building \(name) standard library module into \(output.platformString)", | ||
executable: .targetInThisPackage("BuildStandardLibrary"), | ||
arguments: ["-o", output.platformString] + sources.map(\.platformString), | ||
inputFiles: sources.map(\.spmPath), | ||
outputFiles: [output.spmPath]) | ||
} | ||
|
||
return [ | ||
buildLibrary(name: "hosted", sources: hostedSources), | ||
buildLibrary(name: "freestanding", sources: freestandingSources) | ||
] | ||
} | ||
|
||
} |
Submodule SPMBuildToolSupport
updated
11 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import ArgumentParser | ||
import CBORCoding | ||
import Core | ||
import Foundation | ||
import FrontEnd | ||
import Utils | ||
|
||
/// A command-line tool that generates a Hylo standard library module as part of our build process. | ||
@main | ||
struct BuildStandardLibrary: ParsableCommand { | ||
|
||
@Option( | ||
name: [.customShort("o")], | ||
help: ArgumentHelp("Write output to <file>.", valueName: "module-file"), | ||
transform: URL.init(fileURLWithPath:)) | ||
var outputURL: URL | ||
|
||
@Argument( | ||
help: "The Hylo source files that comprise the library.", | ||
transform: URL.init(fileURLWithPath:)) | ||
var hyloSourceFiles: [URL] | ||
|
||
func run() throws { | ||
try CBOREncoder().forAST | ||
.encode(AST(sources: hyloSourceFiles, for: ConditionalCompilationFactors())) | ||
.write(to: outputURL, options: .atomic) | ||
} | ||
|
||
} | ||
|
||
extension AST { | ||
|
||
/// Creates an instance that includes the Hylo library built from the given `sources`. | ||
init(sources: [URL], for conditions: ConditionalCompilationFactors) throws { | ||
self.init(conditions) | ||
var diagnostics = DiagnosticSet() | ||
coreLibrary = try makeModule( | ||
"Hylo", | ||
sourceCode: sources.map(SourceFile.init(contentsOf:)), | ||
builtinModuleAccess: true, | ||
diagnostics: &diagnostics) | ||
assert(coreModuleIsLoaded) | ||
self.coreTraits = .init(self) | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../GenerateHyloFileTests/FullPathInFatalErrors.swift |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
import CBORCoding | ||
import Core | ||
import FrontEnd | ||
import StandardLibrary | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I loathe operators for pretty much anything other than arithmetic operations on numerics. It is also not at all obvious to me that
/
has to be understood as a path separator when its operands are arbitrary expressions.