-
Notifications
You must be signed in to change notification settings - Fork 31
Display errors if the bundle cannot be loaded #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ot folder instead from build" This reverts commit 8765096.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes some sense to me but I'd like to get input from @rmccue before we move forward.
Looks alright to me. Where are the styles for this error taken from? Could we copy CRA's error styling instead? (You can use react-wp-ssr's exception handler and CSS as an easy way to grab that.) |
@kadamwhite @rmccue I've updated the PR:
Here's a sample: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, if we're going to have monospaced text, we should keep the content plain text. I'd drop the ULs here in favour of just straight up text, or show the error differently.
@rmccue Thanks, should be solved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😗 👌
This is a bit crazy idea but I created a script that will display an error in case the bundles are not found or cannot be loaded. I believe that falling back into production bundles if the dev ones aren't found is not a good idea as it could confuse developers. This will display an error with some details.