Correctly get all HID descriptors #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to use the interface number and index, but then most devices just reply with LIBUSB_TRANSFER_STALL (not supported) anyway.
|
@GamePad64 please |
nacho
reviewed
Nov 23, 2023
| if (g_error_matches(error_local, | ||
| G_USB_DEVICE_ERROR, | ||
| G_USB_DEVICE_ERROR_NOT_SUPPORTED)) { | ||
| g_debug("ignoring: %s", error_local->message); |
There was a problem hiding this comment.
I kind of feel that it would be more correct to report an error than an empty buffer
There was a problem hiding this comment.
I initially thought so too; but I've yet to find a device that reports two HID descriptors and actually allows you to request the non-default one. I suspect we have a deeper bug somewhere, but interestingly sudo lsusb -vvvv also shows the same fault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to use the interface number and index, but then most devices just reply with LIBUSB_TRANSFER_STALL (not supported) anyway.