Skip to content

[Gradient checkpoining] Correct disabling find_unused_parameters in Trainer when gradient checkpointing is enabled #13961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Oct 11, 2021

What does this PR do?

Following #13657 this PR makes sure that the Trainer uses the new gradient_checkpointing logic to disable find_unused_parameters argument in DDP.

@sgugger - don't think many people have switched from self.config._gradient_checkpointing to the new API yet, but for those that have previously find_unused_parameters would not have been set to False which then leads to some hard to debug problems like: https://discuss.pytorch.org/t/finding-the-cause-of-runtimeerror-expected-to-mark-a-variable-ready-only-once/124428/5

Not sure if this worth a patch or not

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing! The check in the Trainer was changed to match the intermediate iteration in the PR for gradient checkpointing and I forgot to adapt it to the last one.

@patrickvonplaten patrickvonplaten merged commit dca6796 into huggingface:master Oct 11, 2021
@patrickvonplaten patrickvonplaten deleted the correct_gradient_checkpointing branch October 11, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants