Skip to content

Align step numbers in monitoring logging #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

spemed
Copy link
Contributor

@spemed spemed commented Feb 16, 2025

Change-Id: I751c96e2dac113303006d1636b7122150ca165e8

WechatIMG174

Adjust the Monitor class in src/smolagents/monitoring.py. Adjust the following code:
console_outputs = f"[Step {len(self.step_durations)-1}: Duration {step_duration:.2f} seconds"
Modify the step counter so that it can match the main title in each block, reducing confusion.

…sole log to make it consistent with the content in the main title.

Change-Id: I751c96e2dac113303006d1636b7122150ca165e8
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just wondering why you opened 3 Pull Requests to propose this change:

Do you know that you can modify an existing PR instead of opening a new one for each modification?

@albertvillanova albertvillanova changed the title feat(update Monitor): Modify the value of the Step counter in the console log to make it consistent with the content in the main title. Align step numbers in monitoring logging Feb 17, 2025
@albertvillanova albertvillanova merged commit 1a272f6 into huggingface:main Feb 17, 2025
@spemed
Copy link
Contributor Author

spemed commented Feb 17, 2025

Thanks. Just wondering why you opened 3 Pull Requests to propose this change:

Do you know that you can modify an existing PR instead of opening a new one for each modification?

Hello, I know that. It seems that I had some network issues here yesterday, which caused me to submit the request multiple times. My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants