Move contributing details into contributing file #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamTheCoder
commented
Feb 14, 2025
CONTRIBUTING.md
Outdated
| @@ -83,6 +86,32 @@ If there is a new feature you'd like to see in smolagents, please open an issue | |||
|
|
|||
| If your issue is well written we're already 80% of the way there by the time you create it. | |||
|
|
|||
| ### Code changes | |||
There was a problem hiding this comment.
This title is added, everything else in this file is existing text
|
Yeah I agree it makes more sense. I was slightly worried about putting code blocks before the bit that non-coders should read. |
There was a problem hiding this comment.
Thank you again! I totally agree: I think it would be better to sort the sections from lower to higher complexity.
What about this order?
## Ways to contribute
There are several ways you can contribute to smolagents.
- * Fix outstanding issues with the existing code.
* Submit issues related to bugs or desired new features.
* Contribute to the examples or to the documentation.
+ * Fix outstanding issues with the existing code.
|
Great, that's hopefully now an improvement for all types of contributor |
albertvillanova
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is where I looked at least. I've kept the existing text I've moved exactly the same.