Delete prompts_path argument and use prompt_templates #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
changed the title
|
@albertvillanova the "s" in |
|
I need to resolve the conflicts after having merged: I aligned the singular name with |
|
What about both in plural (for explicit clarity)?
|
albertvillanova
changed the title
|
Finally:
|
| @@ -779,10 +780,13 @@ def __init__( | |||
| ): | |||
| self.additional_authorized_imports = additional_authorized_imports if additional_authorized_imports else [] | |||
| self.authorized_imports = list(set(BASE_BUILTIN_MODULES) | set(self.additional_authorized_imports)) | |||
| self.prompt_templates = yaml.safe_load(importlib.resources.read_text("smolagents.prompts", "code_agent.yaml")) | |||
| prompt_templates = prompt_templates or yaml.safe_load( | |||
There was a problem hiding this comment.
Love this, really clean!
aymeric-roucher
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT:
Remove unused
prompts_pathargument and useprompt_templatesinstead.EDIT:
Useprompt_pathargument, previously introduced but not used.Remove unusedprompts_pathargument.This argument was introduced (but not used) in:
Or maybe you wanted to use it somehow? @aymeric-roucher