Fix vlm_web_browser.py example
#410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A typo which meant that the images were never being remove for lean processing
abidlabs
changed the title
vlm_web_browser.py examplevlm_web_browser.py example
abidlabs
commented
Jan 29, 2025
examples/vlm_web_browser.py
Outdated
| @@ -48,7 +48,7 @@ def save_screenshot(step_log: ActionStep, agent: CodeAgent) -> None: | |||
| current_step = step_log.step_number | |||
| if driver is not None: | |||
| for step_logs in agent.logs: # Remove previous screenshots from logs for lean processing | |||
| if isinstance(step_log, ActionStep) and step_log.step_number <= current_step - 2: | |||
| if isinstance(step_logs, ActionStep) and step_logs.step_number <= current_step - 2: | |||
There was a problem hiding this comment.
Would be better to just rename this to avoid potential issues with step_logs <> step_log but in the interest of keeping the diff minimal, left the PR like this
|
Note: I am also pretty sure there's a typo on line 60: should be: but wasn't 100% sure I understood the rationale for this line so I didn't make the change in this PR |
aymeric-roucher
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A typo which meant that the older images were never actually being removed