fix typo in building_good_agents.md #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function get_coordinates_from_location should be actually convert_location_to_coordinates
|
Why do you think the name |
Closed
because some rows below that function is meant to be called, but instead it is called 'convert_location_to_coordinates' . So one of the two is right and the other is wrong. Since in the subsequent example on the same page the function 'convert_location_to_coordinates' is called again, I supposed that this is the right name (by majority vote, in some sense.) |
|
Oh ok, I see your point! Thank you for proposing this! |
aymeric-roucher
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function get_coordinates_from_location should be actually convert_location_to_coordinates